Skip to content

fix: Show button when fetching columns#6891

Merged
rishabhrathod01 merged 2 commits intoreleasefrom
fix/gen-crud-submit-btn
Aug 26, 2021
Merged

fix: Show button when fetching columns#6891
rishabhrathod01 merged 2 commits intoreleasefrom
fix/gen-crud-submit-btn

Conversation

@rishabhrathod01
Copy link
Contributor

@rishabhrathod01 rishabhrathod01 commented Aug 25, 2021

Description

Avoid hiding of submit button when fetching column headers when selected google sheets as datasource to generate CRUD page.

Also disabled text selection for the Button component.

Fixes #

Type of change

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

Manually in local.

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

Test coverage results 🧪

⚪ Total coverage has not changed
// Code coverage diff between base branch:release and head branch: fix/gen-crud-submit-btn 
Status File % Stmts % Branch % Funcs % Lines
🟢 app/client/src/pages/Editor/GeneratePage/components/GeneratePageForm/GoogleSheetForm.tsx 27.66 (0) 14.43 (0.29) 0 (0) 30.95 (0)

Loading
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Generate Page Issures related to page generation skip-changelog Adding this label to a PR prevents it from being listed in the changelog

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants